]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
worker_thread: fix racy try_to_freeze() usage
authorOleg Nesterov <oleg@tv-sign.ru>
Wed, 9 May 2007 09:34:20 +0000 (02:34 -0700)
committerLinus Torvalds <torvalds@woody.linux-foundation.org>
Wed, 9 May 2007 19:30:53 +0000 (12:30 -0700)
commit85f4186af944c1240c84934a9ab578743df2d69b
tree743d6a619538cda98495aaaac67a86246d3007e4
parentb9aac8e0d32499217417ff0b494731811f185b18
worker_thread: fix racy try_to_freeze() usage

worker_thread() can miss freeze_process()->signal_wake_up() if it happens
between try_to_freeze() and prepare_to_wait().  We should check freezing()
before entering schedule().

This race was introduced by me in

[PATCH 1/1] workqueue: don't migrate pending works from the dead CPU

Looks like mm/vmscan.c:kswapd() has the same race.

Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
kernel/workqueue.c