]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
mac80211: Fix sleeping allocation under lock in mesh_path_node_copy.
authorPavel Emelyanov <xemul@openvz.org>
Wed, 7 May 2008 15:51:51 +0000 (19:51 +0400)
committerJohn W. Linville <linville@tuxdriver.com>
Thu, 22 May 2008 01:47:44 +0000 (21:47 -0400)
commit8566dc3fca470454461b161677a5ae3bb3a8c1b8
treeeb06d27e69ed8f335d897b5073642a10692c9a8f
parent00242c40a167113688dd7ed46ec94e8a4c47f603
mac80211: Fix sleeping allocation under lock in mesh_path_node_copy.

The mesh_path_node_copy() can be called like this:
mesh_path_add
 `- write_lock(&pathtbl_resize_lock); /* ! */
 `- mesh_table_grow
     `- ->copy_node
           `- mesh_path_node_copy

thus, the GFP_KERNEL is not suitable here.

The acceptable fix, I suppose, is make this allocation GPF_ATOMIC -
the mpath_node being allocated is 4 pointers, i.e. this allocation
is small enough to survive even under a moderate memory pressure.

Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
net/mac80211/mesh_pathtbl.c