]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
libata: fix boot panic with SATAPI devices on non-SFF HBAs
authorJames Bottomley <James.Bottomley@HansenPartnership.com>
Fri, 18 Apr 2008 18:18:48 +0000 (13:18 -0500)
committerLinus Torvalds <torvalds@linux-foundation.org>
Fri, 18 Apr 2008 18:20:42 +0000 (11:20 -0700)
commit855d854a33fca71cf68bad258bd5e66e5b265d10
treefcb5cac022d38af474c5243182a3c6f91de0b2ec
parente675349e2bdbfb661fa0d8ff2441b4cf48fb7e48
libata: fix boot panic with SATAPI devices on non-SFF HBAs

The kernel now panics reliably on boot if you have a SATAPI device
connected.

The problem was introduced by the libata merge trying to pull out all
the SFF code into a separate module.  Unfortunately, if you're a satapi
device you usually need to call atapi_request_sense, which has a bare
invocation of a SFF callback which is NULL on non-SFF HBAs.  Fix this by
making the call conditional.

Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/ata/libata-scsi.c