]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
KVM: fix i8259 reset irq acking
authorMarcelo Tosatti <mtosatti@redhat.com>
Thu, 14 Aug 2008 23:53:25 +0000 (20:53 -0300)
committerAvi Kivity <avi@qumranet.com>
Wed, 15 Oct 2008 08:15:19 +0000 (10:15 +0200)
commit85428ac7c39ab5fff23b5d14ccb32941e9401285
tree19e12ebc433e51835e8065eebce515472e7bbafc
parent8ceed34744f81c4a33d68ab825fd9ad3dd5f5505
KVM: fix i8259 reset irq acking

The irq ack during pic reset has three problems:

- Ignores slave/master PIC, using gsi 0-8 for both.
- Generates an ACK even if the APIC is in control.
- Depends upon IMR being clear, which is broken if the irq was masked
at the time it was generated.

The last one causes the BIOS to hang after the first reboot of
Windows installation, since PIT interrupts stop.

[avi: fix check whether pic interrupts are seen by cpu]

Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
Signed-off-by: Avi Kivity <avi@qumranet.com>
arch/x86/kvm/i8259.c