]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
twl4030-core irq simplification
authorDavid Brownell <dbrownell@users.sourceforge.net>
Tue, 7 Oct 2008 03:43:35 +0000 (20:43 -0700)
committerTony Lindgren <tony@atomide.com>
Tue, 7 Oct 2008 08:35:14 +0000 (11:35 +0300)
commit83f474a268ce0a5c704ed26a6e78096837b9046f
tree4faebb9057e733a808ab5899df66d39a0c5c3779
parentbaae8496943a8a2cb141f28c005ee5e6d6b19bbc
twl4030-core irq simplification

Simplify twl4030 IRQ handling by removing a needless custom flow
handler.  The top level IRQs, from the PIH, are well suited for
handle_simple_irq() ... they can't be acked or masked.

Switching resolves some issues with how IRQs were dispatched.
Notably, abuse of desc->status, IRQ accounting, and handling
of various faults.

In short, use standard genirq code.

Drivers that request_irq() to the PIH will need to pay more
attention to things like setting IRQF_DISABLED (since it's
no longer ignored), and making I2C calls from handlers (you'll
need a lockdep workaround).

Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Signed-off-by: Tony Lindgren <tony@atomide.com>
drivers/mfd/twl4030-core.c