]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
USB: fix hcd interrupt disabling
authorGeoff Levand <geoffrey.levand@am.sony.com>
Fri, 22 Aug 2008 21:13:00 +0000 (14:13 -0700)
committerGreg Kroah-Hartman <gregkh@suse.de>
Tue, 23 Sep 2008 20:58:06 +0000 (13:58 -0700)
commit83a798207361cc26385187b2e71efa2b5d75de7f
treeeb2fa06d818abf43b18c9f3ccc7c12acbf62bb3b
parentf8834f1febb8f56cdcfeb35485e0cc7a8d547818
USB: fix hcd interrupt disabling

Commit de85422b94ddb23c021126815ea49414047c13dc, 'USB: fix interrupt
disabling for HCDs with shared interrupt handlers' changed usb_add_hcd()
to strip IRQF_DISABLED from irqflags prior to calling request_irq()
with the justification that such a removal was necessary for shared
interrupts to work properly.  Unfortunately, the change in that commit
unconditionally removes the IRQF_DISABLED flag, causing problems on
platforms that don't use a shared interrupt but require IRQF_DISABLED.
This change adds a check for IRQF_SHARED prior to removing the
IRQF_DISABLED flag.

Fixes the PS3 system startup hang reported with recent Fedora and
OpenSUSE kernels.

Note that this problem is hidden when CONFIG_LOCKDEP=y (ps3_defconfig),
as local_irq_enable_in_hardirq() is defined as a null statement for
that config.

CC: stable <stable@kernel.org>
Signed-off-by: Geoff Levand <geoffrey.levand@am.sony.com>
Cc: Alan Stern <stern@rowland.harvard.edu>
Cc: Stefan Becker <Stefan.Becker@nokia.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/usb/core/hcd.c