]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
ipmi: Fix mem leak in try_init_dmi()
authorJesper Juhl <jesper.juhl@gmail.com>
Tue, 31 Jul 2007 07:39:05 +0000 (00:39 -0700)
committerLinus Torvalds <torvalds@woody.linux-foundation.org>
Tue, 31 Jul 2007 22:39:41 +0000 (15:39 -0700)
commit80cd69203c3ad5f2ecf7d01cec4a10ed15613682
tree8328a64144dcf726e9b7b16c26f7fb5e10ee56a9
parent73c21e8024296760c450a0bded131cb573f83328
ipmi: Fix mem leak in try_init_dmi()

This is only called at init time and only happens if the BIOS screws
something up, so the leak is slight and it is probably not worth sending to
2.6.22.x.  The driver would not initialize the interface in the case, and I
have no reports of this happening.  I have booted and run tests on a system
with this patch.  Note that the original patch was munged by the mailer,
here's a new one.

If we ever hit the "default:" case in the switch in try_init_dmi(),
then we'll leak the storage allocated with kzalloc() and assigned
to 'info'.

Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
Signed-off-by: Corey Minyard <cminyard@mvista.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/char/ipmi/ipmi_si_intf.c