]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
Revert unintentional "volatile" changes in ipc/msg.c
authorLinus Torvalds <torvalds@g5.osdl.org>
Sat, 4 Nov 2006 17:55:00 +0000 (09:55 -0800)
committerLinus Torvalds <torvalds@g5.osdl.org>
Sat, 4 Nov 2006 17:55:00 +0000 (09:55 -0800)
commit80491eb90c750fcd7d13830062f27ae9b7cc5f75
tree81d506d9559c13c090cc853d13f48fcf982795df
parentddac0d39cf437d02fde9795ae57d9c4b4c146de9
Revert unintentional "volatile" changes in ipc/msg.c

Commit 5a06a363ef48444186f18095ae1b932dddbbfa89 ("[PATCH] ipc/msg.c:
clean up coding style") breaks fakeroot on Alpha (variously hangs or
oopses), according to a report by Falk Hueffner.

The fact that the code seems to rely on compiler access ordering through
the use of "volatile" is a pretty certain sign that the code has locking
problems, and we should fix those properly and then remove the whole
"volatile" entirely.

But in the meantime, the movement of "volatile" was unintentional, and
should be reverted.

Cc: Falk Hueffner <falk@debian.org>
Cc: Andrew Morton <akpm@osdl.org>
Acked-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
ipc/msg.c