]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
hrtimer: fix rq->lock inversion (again)
authorPeter Zijlstra <a.p.zijlstra@chello.nl>
Fri, 13 Mar 2009 11:21:27 +0000 (12:21 +0100)
committerIngo Molnar <mingo@elte.hu>
Tue, 31 Mar 2009 12:52:52 +0000 (14:52 +0200)
commit7f1e2ca9f04b02794597f60e7b1d43f0a1317939
treedad1d80ab4232f3ca12d7ff9a58f0dc76133dab1
parent7bee946358c3cb957d4aa648fc5ab3cad0b232d0
hrtimer: fix rq->lock inversion (again)

It appears I inadvertly introduced rq->lock recursion to the
hrtimer_start() path when I delegated running already expired
timers to softirq context.

This patch fixes it by introducing a __hrtimer_start_range_ns()
method that will not use raise_softirq_irqoff() but
__raise_softirq_irqoff() which avoids the wakeup.

It then also changes schedule() to check for pending softirqs and
do the wakeup then, I'm not quite sure I like this last bit, nor
am I convinced its really needed.

Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: paulus@samba.org
LKML-Reference: <20090313112301.096138802@chello.nl>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
include/linux/hrtimer.h
include/linux/interrupt.h
kernel/hrtimer.c
kernel/sched.c
kernel/softirq.c