]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
virtio: fix virtio_net xmit of freed skb bug
authorRusty Russell <rusty@rustcorp.com.au>
Mon, 26 May 2008 07:42:42 +0000 (17:42 +1000)
committerJeff Garzik <jgarzik@redhat.com>
Sat, 31 May 2008 02:07:20 +0000 (22:07 -0400)
commit7eb2e25112bf920bb0a4d1cca445f3d96874c25f
treecb26b7adfe4c8af39361716966049ed8dd4732d0
parentd399cf8c04c595d738d82d02ae2755b902a51571
virtio: fix virtio_net xmit of freed skb bug

If we fail to transmit a packet, we assume the queue is full and put
the skb into last_xmit_skb.  However, if more space frees up before we
xmit it, we loop, and the result can be transmitting the same skb twice.

Fix is simple: set skb to NULL if we've used it in some way, and check
before sending.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
drivers/net/virtio_net.c