]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
[PATCH] mm: add a note about partially hardcoded VM_* flags
authorPaolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
Wed, 21 Sep 2005 16:55:39 +0000 (09:55 -0700)
committerLinus Torvalds <torvalds@g5.osdl.org>
Wed, 21 Sep 2005 17:11:55 +0000 (10:11 -0700)
commit7e2cff42cfac27c25202648c5c89f9171e5bc085
tree5579fa13b1fc8081201f05d687e6dc795d9d648f
parent7e871b6c8f1f4fda41e51ef86147facecac3be9f
[PATCH] mm: add a note about partially hardcoded VM_* flags

Hugh made me note this line for permission checking in mprotect():

if ((newflags & ~(newflags >> 4)) & 0xf) {

after figuring out what's that about, I decided it's nasty enough.  Btw
Hugh itself didn't like the 0xf.

We can safely change it to VM_READ|VM_WRITE|VM_EXEC because we never change
VM_SHARED, so no need to check that.

Signed-off-by: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
Acked-by: Hugh Dickins <hugh@veritas.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
include/linux/mm.h
mm/mprotect.c