]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
arch/sh/mm: Move a dereference below a NULL test
authorJulia Lawall <julia@diku.dk>
Fri, 26 Dec 2008 07:27:24 +0000 (08:27 +0100)
committerPaul Mundt <lethal@linux-sh.org>
Wed, 21 Jan 2009 08:41:14 +0000 (17:41 +0900)
commit7bfa122c19e47b1dee47476ce6e9ed6ba16f8269
tree84550953efedb635b8c25c2c7273eeec141c5106
parentf3b8436ad9a8ad36b3c9fa1fe030c7f38e5d3d0b
arch/sh/mm: Move a dereference below a NULL test

If the NULL test is necessary, then the dereference should be moved below
the NULL test.

The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/).

// <smpl>
@disable is_null@
identifier f;
expression E;
identifier fld;
statement S;
@@

+ if (E == NULL) S
  f(...,E->fld,...);
- if (E == NULL) S

@@
identifier f;
expression E;
identifier fld;
statement S;
@@

+ if (!E) S
  f(...,E->fld,...);
- if (!E) S
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Paul Mundt <lethal@linux-sh.org>
arch/sh/mm/ioremap_64.c