]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
[SCSI] aic7xxx: fix byte I/O order in ahd_inw
authorDenis Vlasenko <vda.linux@googlemail.com>
Mon, 25 Sep 2006 23:57:42 +0000 (16:57 -0700)
committerJames Bottomley <jejb@mulgrave.il.steeleye.com>
Sun, 1 Oct 2006 20:03:38 +0000 (15:03 -0500)
commit7b75b990e3cb33fd529640d589e77950e72a607c
tree1e282b2af06644587687f02d86419f604d87a907
parent02a0fa676cd453ce4254c2eee838307ffc5c37f4
[SCSI] aic7xxx: fix byte I/O order in ahd_inw

Comment says "Read high byte first as some registers increment..."
but code doesn't guarantee that, I think:
return ((ahd_inb(ahd, port+1) << 8) | ahd_inb(ahd, port));
Compiler can reorder it.

Make the order explicit.

Signed-off-by: Denis Vlasenko <vda.linux@googlemail.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Fixed rejections and added aic7xxx code
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
drivers/scsi/aic7xxx/aic79xx_inline.h
drivers/scsi/aic7xxx/aic7xxx_inline.h