]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
jbd2: don't dirty original metadata buffer on abort
authorHidehiro Kawai <hidehiro.kawai.ez@hitachi.com>
Sat, 11 Oct 2008 00:29:31 +0000 (20:29 -0400)
committerTheodore Ts'o <tytso@mit.edu>
Sat, 11 Oct 2008 00:29:31 +0000 (20:29 -0400)
commit7ad7445f60fe4d46c4c9d2a9463db180d2a3b270
treecd4e0f69f90664e5ca4185271fbacbb7b4f59491
parent7ffe1ea8949c75ecffb7a4d988bb881a9fa62fbe
jbd2: don't dirty original metadata buffer on abort

Currently, original metadata buffers are dirtied when they are
unfiled whether the journal has aborted or not.  Eventually these
buffers will be written-back to the filesystem by pdflush.  This
means some metadata buffers are written to the filesystem without
journaling if the journal aborts.  So if both journal abort and
system crash happen at the same time, the filesystem would become
inconsistent state.  Additionally, replaying journaled metadata
can overwrite the latest metadata on the filesystem partly.
Because, if the journal gets aborted, journaled metadata are
preserved and replayed during the next mount not to lose
uncheckpointed metadata.  This would also break the consistency
of the filesystem.

This patch prevents original metadata buffers from being dirtied
on abort by clearing BH_JBDDirty flag from those buffers.  Thus,
no metadata buffers are written to the filesystem without journaling.

Signed-off-by: Hidehiro Kawai <hidehiro.kawai.ez@hitachi.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
fs/jbd2/commit.c