]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
sched: fix regression with sched yield
authorPeter Zijlstra <a.p.zijlstra@chello.nl>
Mon, 18 Feb 2008 12:39:37 +0000 (13:39 +0100)
committerIngo Molnar <mingo@elte.hu>
Sat, 19 Apr 2008 17:44:57 +0000 (19:44 +0200)
commit79b3feffb10417f197d2ab48dd4fa3c0c9e7d788
tree78b754d36beddd15f43723faa861e06b239ca47b
parent19fb518c2a0c5d88ed22bba7083b7e7bc2a9c231
sched: fix regression with sched yield

Balbir Singh reported:

> 1:mon> t
> [c0000000e7677da0c000000000067de0 .sys_sched_yield+0x6c/0xbc
> [c0000000e7677e30c000000000008748 syscall_exit+0x0/0x40
> --- Exception: c01 (System Call) at 00000400001d09e4
> SP (4000664cb10) is in userspace
> 1:mon> r
> cpu 0x1: Vector: 300 (Data Access) at [c0000000e7677aa0]
>     pc: c000000000068e50: .yield_task_fair+0x94/0xc4
>     lr: c000000000067de0: .sys_sched_yield+0x6c/0xbc

the check that should have avoided that is:

        /*
         * Are we the only task in the tree?
         */
        if (unlikely(rq->load.weight == curr->se.load.weight))
                return;

But I guess that overlooks rt tasks, they also increase the load.
So I guess something like this ought to fix it..

Signed-off-by: Ingo Molnar <mingo@elte.hu>
kernel/sched_fair.c