]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
[PATCH] mac80211: fix virtual interface locking
authorJohannes Berg <johannes@sipsolutions.net>
Tue, 18 Sep 2007 21:29:21 +0000 (17:29 -0400)
committerDavid S. Miller <davem@sunset.davemloft.net>
Wed, 10 Oct 2007 23:53:00 +0000 (16:53 -0700)
commit79010420cc3f78eab911598bfdd29c4b06a83e1f
treea9031164d7944f8aa90a455d297780b241f3d865
parentea49c359f36d5b40bf033c45a08332cb73777aa2
[PATCH] mac80211: fix virtual interface locking

Florian Lohoff noticed a bug in mac80211: when bringing the
master interface down while other virtual interfaces are up
we call dev_close() under a spinlock which is not allowed.
This patch removes the sub_if_lock used by mac80211 in favour
of using an RCU list. All list manipulations are already done
under rtnl so are well protected against each other, and the
read-side locks we took in the RX and TX code are already in
RCU read-side critical sections.

Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Cc: Florian Lohoff <flo@rfc822.org>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Michal Piotrowski <michal.k.k.piotrowski@gmail.com>
Cc: Satyam Sharma <satyam@infradead.org>
Signed-off-by: Michael Wu <flamingice@sourmilk.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
net/mac80211/ieee80211.c
net/mac80211/ieee80211_i.h
net/mac80211/ieee80211_iface.c
net/mac80211/ieee80211_sta.c
net/mac80211/rx.c
net/mac80211/tx.c