]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
libata: fix translation for START STOP UNIT
authorRobert Hancock <hancockr@shaw.ca>
Tue, 30 Jan 2007 08:59:18 +0000 (00:59 -0800)
committerJeff Garzik <jeff@garzik.org>
Tue, 30 Jan 2007 14:20:39 +0000 (09:20 -0500)
commit78981a7c6c34bddbb90da72cf6ce10953e84aad8
tree65e9f6dc9e9c0e8462a32e09e511ef81617264d8
parentaf068bd1debcc76c1bc265aa01401901bf0067ed
libata: fix translation for START STOP UNIT

libata's SCSI translation for the SCSI START STOP UNIT command with the
START bit clear (i.e.  stopping the drive) appears to be incorrect.  It
sends an ATA STANDBY command with the time period set to 0, which the code
comment says means "now", but the ATA standard says this means disable the
standby timer, which effectively does nothing.  Change this to issue a
STANDBY IMMEDIATE command which will actually spin the drive down.  The SAT
(SCSI/ATA Translation) standard revision 9 concurs with this choice.

Signed-off-by: Robert Hancock <hancockr@shaw.ca>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
drivers/ata/libata-scsi.c