]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
Fix accidental implicit cast in HR-timer conversion
authorDavid Howells <dhowells@redhat.com>
Wed, 5 Nov 2008 17:38:47 +0000 (17:38 +0000)
committerLinus Torvalds <torvalds@linux-foundation.org>
Thu, 6 Nov 2008 23:44:19 +0000 (15:44 -0800)
commit7597bc94d6f3bdccb086ac7f2ad91292fdaee2a4
tree17126979600f74f27b45669861808e577c305920
parentc36194871293100bd4b2ecb54ac9774d6e627aa2
Fix accidental implicit cast in HR-timer conversion

Fix the hrtimer_add_expires_ns() function.  It should take a 'u64 ns' argument,
but rather takes an 'unsigned long ns' argument - which might only be 32-bits.

On FRV, this results in the kernel locking up because hrtimer_forward() passes
the result of a 64-bit multiplication to this function, for which the compiler
discards the top 32-bits - something that didn't happen when ktime_add_ns() was
called directly.

Signed-off-by: David Howells <dhowells@redhat.com>
Acked-by: Arjan van de Ven <arjan@linux.intel.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
include/linux/hrtimer.h