]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
pkt_sched: cls_u32: Fix locking in u32_change()
authorJarek Poplawski <jarkao2@gmail.com>
Tue, 6 Jan 2009 02:14:19 +0000 (18:14 -0800)
committerDavid S. Miller <davem@davemloft.net>
Tue, 6 Jan 2009 02:14:19 +0000 (18:14 -0800)
commit6f57321422e0d359e83c978c2b03db77b967b7d5
tree80d92a8fff5b5ae27ca618f34acf9d696289d6ba
parentf1d3e4dca3f8d4f55656477e83d0afe0ea7cbaed
pkt_sched: cls_u32: Fix locking in u32_change()

New nodes are inserted in u32_change() under rtnl_lock() with wmb(),
so without tcf_tree_lock() like in other classifiers (e.g. cls_fw).
This isn't enough without rmb() on the read side, but on the other
hand adding such barriers doesn't give any savings, so the lock is
added instead.

Reported-by: m0sia <m0sia@plotinka.ru>
Signed-off-by: Jarek Poplawski <jarkao2@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sched/cls_u32.c