]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
x86: Mark OPTIMIZE_INLINING broken
authorLinus Torvalds <torvalds@linux-foundation.org>
Thu, 1 May 2008 02:50:03 +0000 (19:50 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Thu, 1 May 2008 03:07:22 +0000 (20:07 -0700)
commit6d98ca736441029e4e87ad3b6dc4a8645dc4c6d3
tree5aab64f86dc6697bba085884c28f32ea031a1e99
parent958a2f29a6520a1d2973077ce7854ea9a44f48a2
x86: Mark OPTIMIZE_INLINING broken

So Ingo finally did figure out why UML broke with this option: UML
passes gcc the -fno-unit-at-a-time flag, and apparently that wreaks
havoc with gcc's inlining.

We could turn off -fno-unit-at-a-time for UML for gcc4+ (which is what
x86 does), but there's bad blood about this whole option, and it does
show that the thing is just fragile as heck.

So let tempers cool, and disable the thing, and we can revisit the
decision later.

Cc: Adrian Bunk <bunk@kernel.org>
Cc: David Miller <davem@davemloft.net>
Acked-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
arch/x86/Kconfig.debug