]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
ieee1394: regression in 2.6.25: updates should happen before probes
authorStefan Richter <stefanr@s5r6.in-berlin.de>
Sat, 16 Aug 2008 11:36:47 +0000 (13:36 +0200)
committerStefan Richter <stefanr@s5r6.in-berlin.de>
Tue, 19 Aug 2008 16:47:55 +0000 (18:47 +0200)
commit6848408abf1bc18d9a4d5fed3fcca812745ece05
treecc52f981e49461426bc747821d0c133de20d7134
parent1fca25427482387689fa27594c992a961d98768f
ieee1394: regression in 2.6.25: updates should happen before probes

Regression since commit 73cf60232ef16e1f8a64defa97214a1722db1e6c,
"ieee1394: use class iteration api":  The two loops for (1.) driver
updates and (2.) driver probes were replaced by a single loop with
bogus needs_probe checks.  Hence updates and probes were now intermixed,
and especially sbp2 updates (reconnects) held up longer than necessary.

While we fix it, change the needs_probe flag to bool type for clarity.

Tested by Damien Benoist.

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
drivers/ieee1394/nodemgr.c
drivers/ieee1394/nodemgr.h