]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
[PATCH] Fix mmap() of /dev/hpet
authorKeir Fraser <Keir.Fraser@cl.cam.ac.uk>
Fri, 23 Sep 2005 04:43:59 +0000 (21:43 -0700)
committerLinus Torvalds <torvalds@g5.osdl.org>
Fri, 23 Sep 2005 05:17:34 +0000 (22:17 -0700)
commit609725f87709724218047a1049913ed233f79d3c
tree7ccc4b12808b4de7d248ba7a722637f244155f26
parent7243cc05bafdda4c4de77cba00cf87666bd237f7
[PATCH] Fix mmap() of /dev/hpet

The address passed to io_remap_pfn_range() in hpet_mmap() does not need to
be converted using __pa(): it is already a physical address.  This bug was
found and the patch suggested by Clay Harris.

I introduced this particular bug when making io_remap_pfn_range changes a
few months ago.  In fact mmap()ing /dev/hpet has *never* previously worked:
before my changes __pa() was being executed on an ioremap()ed virtual
address, which is also invalid.

Signed-off-by: Keir Fraser <keir@xensource.com>
Cc: Robert Picco <Robert.Picco@hp.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
drivers/char/hpet.c