]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
[PATCH] x86: AUX_DEVICE_INFO is one byte long, use 'movb'
authorDiego Calleja <diegocg@gmail.com>
Tue, 26 Sep 2006 08:52:30 +0000 (10:52 +0200)
committerAndi Kleen <andi@basil.nowhere.org>
Tue, 26 Sep 2006 08:52:30 +0000 (10:52 +0200)
commit606bd58de6542e847c51b1b6d83a4cd70a632fe7
treee7ff122d738c2ce73f01f2c8dd6517c9f960fdc9
parentcf4c6a2f27f5db810b69dcb1da7f194489e8ff88
[PATCH] x86: AUX_DEVICE_INFO is one byte long, use 'movb'

Bugzilla #6552 says:

"In arch/i386/boot/setup.S, movw is used instead of movb for PS/2 mouse
information, although it is unsigned char. This does not harm, because
the jmp instruction overwritten by movw is used before executing movw,
and never be used again"

I've no idea if this is a real bug or how it gets fixed, so I'm submitting
it for review instead of letting it die of boredom in bugzilla. Aditionally
to i386, I've changed x86-64, which mirrors the same code.

Credits to Yoshinori K. Okuji, who found the problem and suggested a fix.

Signed-off-by: Diego Calleja <diegocg@gmail.com>
Signed-off-by: Andi Kleen <ak@suse.de>
arch/i386/boot/setup.S
arch/x86_64/boot/setup.S