]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
powerpc/spufs: Fix spinning in spufs_ps_fault on signal
authorJeremy Kerr <jk@ozlabs.org>
Mon, 10 Nov 2008 23:22:22 +0000 (10:22 +1100)
committerJeremy Kerr <jk@ozlabs.org>
Thu, 20 Nov 2008 23:14:16 +0000 (10:14 +1100)
commit606572634c3faa5b32a8fc430266e6e9d78d2179
tree9ae7cd7985d1d04f40f4e2260b32b671968432f5
parent34318c253b861f82bd4a2956e6c8ae8ee2c3aae7
powerpc/spufs: Fix spinning in spufs_ps_fault on signal

Currently, we can end up in an infinite loop if we get a signal
while the kernel has faulted in spufs_ps_fault. Eg:

 alarm(1);

 write(fd, some_spu_psmap_register_address, 4);

- the write's copy_from_user will fault on the ps mapping, and
signal_pending will be non-zero. Because returning from the fault
handler will never clear TIF_SIGPENDING, so we'll just keep faulting,
resulting in an unkillable process using 100% of CPU.

This change returns VM_FAULT_SIGBUS if there's a fatal signal pending,
letting us escape the loop.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
arch/powerpc/platforms/cell/spufs/file.c