]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
ext3: allocate ->s_blockgroup_lock separately
authorPekka Enberg <penberg@cs.helsinki.fi>
Thu, 8 Jan 2009 02:07:25 +0000 (18:07 -0800)
committerLinus Torvalds <torvalds@linux-foundation.org>
Thu, 8 Jan 2009 16:31:00 +0000 (08:31 -0800)
commit5df096d67ec2b6578518caed7d57317a4b807aa1
tree8e92d19c89dea347eed6fc018fc6e4388bf9ebdc
parentf420d4dc4272fd223986762df2ad06056ddebada
ext3: allocate ->s_blockgroup_lock separately

As spotted by kmemtrace, struct ext3_sb_info is 17152 bytes on 64-bit
which makes it a very bad fit for SLAB allocators.  The culprit of the
wasted memory is ->s_blockgroup_lock which can be as big as 16 KB when
NR_CPUS >= 32.

To fix that, allocate ->s_blockgroup_lock, which fits nicely in a order 2
page in the worst case, separately.  This shinks down struct ext3_sb_info
enough to fit a 1 KB slab cache so now we allocate 16 KB + 1 KB instead of
32 KB saving 15 KB of memory.

Acked-by: Andreas Dilger <adilger@sun.com>
Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: <linux-ext4@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
fs/ext3/super.c
include/linux/ext3_fs_sb.h