]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
[PATCH] Correct misc_register return code handling in several drivers
authorNeil Horman <nhorman@tuxdriver.com>
Thu, 7 Dec 2006 04:37:08 +0000 (20:37 -0800)
committerLinus Torvalds <torvalds@woody.osdl.org>
Thu, 7 Dec 2006 16:39:35 +0000 (08:39 -0800)
commit5d469ec0f40d65b2a0a704402990a43b2dafe197
treee633e67ac9387042617f9de843f020d6116b2d84
parentdc168427e6250a5a24c59f34afed6538092dab42
[PATCH] Correct misc_register return code handling in several drivers

Clean up several code points in which the return code from misc_register is
not handled properly.

Several modules failed to deregister various hooks when misc_register fails,
and this patch cleans them up.  Also there are a few modules that legitimately
don't care about the failure status of misc register.  These drivers however
unilaterally call misc_deregister on module unload.

Since misc_register doesn't initialize the list_head in the init_routine if it
fails, the deregister operation is at risk for oopsing when list_del is
called.  The initial solution was to manually init the list in the miscdev
structure in each of those modules, but the consensus in this thread was to
consolodate and do that universally inside misc_register.

Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
Cc: Bjorn Helgaas <bjorn.helgaas@hp.com>
Cc: Kylene Jo Hall <kjhall@us.ibm.com>
Cc: Dmitry Torokhov <dtor@mail.ru>
Cc: Olaf Hering <olh@suse.de>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
drivers/char/misc.c
drivers/char/mmtimer.c
drivers/char/tpm/tpm.c
drivers/input/misc/hp_sdc_rtc.c
drivers/macintosh/apm_emu.c