]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
[SCSI] qla2xxx: Return a FAILED status when abort mailbox-command fails.
authorMichael Reed <mdr@sgi.com>
Fri, 24 Oct 2008 22:13:47 +0000 (15:13 -0700)
committerJames Bottomley <James.Bottomley@HansenPartnership.com>
Wed, 5 Nov 2008 17:42:12 +0000 (12:42 -0500)
commit5bff55db3dc4d659f46b4d2fce2f61c1964c2762
treedacb58c042b09406345cfa0cb3f67dae500aa2cc
parent680d7db88ace53c673e1c437c9b6abcc053e8d6f
[SCSI] qla2xxx: Return a FAILED status when abort mailbox-command fails.

Mike Reed noted
(https://bugzilla.novell.com/show_bug.cgi?id=421330) that the
driver was incorrectly returning a SUCCESS status if the driver's
request to the firmware to abort a command failed.  By doing so,
the mid-layer believed, incorrectly, that the command has
completed and has been returned (ultimately clearing
scsi_cmnd.request_buffer) yet the driver still has the command.
What should correctly happen is a mid-layer escalation
(device-reset, etc.) of recovery during which the driver will
eventually return the outstanding commands to the mid-layer.

Cc: Stable Tree <stable@kernel.org>
Signed-off-by: Andrew Vasquez <andrew.vasquez@qlogic.com>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
drivers/scsi/qla2xxx/qla_os.c