]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
[ICMP]: ICMP_MIB_OUTMSGS increment duplicated
authorWang Chen <wangchen@cn.fujitsu.com>
Mon, 21 Jan 2008 11:39:45 +0000 (03:39 -0800)
committerDavid S. Miller <davem@davemloft.net>
Mon, 21 Jan 2008 11:39:45 +0000 (03:39 -0800)
commit5b4d383a1a562de6955cacd72e20809064ee137f
tree461579467e46a46611c8e3745bc9cb5fa7d41a99
parentfa95c28322a312a798a688c655458ab2079b72eb
[ICMP]: ICMP_MIB_OUTMSGS increment duplicated

Commit "96793b482540f3a26e2188eaf75cb56b7829d3e3" (Add ICMPMsgStats
MIB (RFC 4293)) made a mistake.

In that patch, David L added a icmp_out_count() in
ip_push_pending_frames(), remove icmp_out_count() from
icmp_reply(). But he forgot to remove icmp_out_count() from
icmp_send() too.  Since icmp_send and icmp_reply will call
icmp_push_reply, which will call ip_push_pending_frames, a duplicated
increment happened in icmp_send.

This patch remove the icmp_out_count from icmp_send too.

Signed-off-by: Wang Chen <wangchen@cn.fujitsu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/icmp.c