]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
firewire: fw-sbp2: use device generation, not card generation
authorStefan Richter <stefanr@s5r6.in-berlin.de>
Thu, 24 Jan 2008 00:53:19 +0000 (01:53 +0100)
committerStefan Richter <stefanr@s5r6.in-berlin.de>
Wed, 30 Jan 2008 21:22:26 +0000 (22:22 +0100)
commit5a8a1bcd15dfb9f177f3605fe6b9ba2bef2bf55a
treef74aad717dc774991e866400179c90064e6eaa0d
parent14dc992aa782f8759c6d117d4322db62f62600ce
firewire: fw-sbp2: use device generation, not card generation

There was a small window where a login or reconnect job could use an
already updated card generation with an outdated node ID.  We have to
use the fw_device.generation here, not the fw_card.generation, because
the generation must never be newer than the node ID when we emit a
transaction.  This cannot be guaranteed with fw_card.generation.

Furthermore, the target's and initiator's node IDs can be obtained from
fw_device and fw_card.  Dereferencing their underlying topology objects
is not necessary.

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
Verified in concert with subsequent memory barriers patch to fix 'giving
up on config rom' issues on multiple system and drive combinations that
were previously affected.

Signed-off-by: Jarod Wilson <jwilson@redhat.com>
drivers/firewire/fw-sbp2.c