]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
[PATCH] file: kill unnecessary timer in fdtable_defer
authorTejun Heo <htejun@gmail.com>
Thu, 7 Dec 2006 04:36:01 +0000 (20:36 -0800)
committerLinus Torvalds <torvalds@woody.osdl.org>
Thu, 7 Dec 2006 16:39:32 +0000 (08:39 -0800)
commit593be07ae8f6f4a1b1b98813fabb155328f8bc0c
tree570686c676986d79ff0868f88c499a8b8fc1d3b4
parente59e2ae2c29700117a54e85c106017c24837119f
[PATCH] file: kill unnecessary timer in fdtable_defer

free_fdtable_rc() schedules timer to reschedule fddef->wq if
schedule_work() on it returns 0.  However, schedule_work() guarantees that
the target work is executed at least once after the scheduling regardless
of its return value.  0 return simply means that the work was already
pending and thus no further action was required.

Another problem is that it used contant '5' as @expires argument to
mod_timer().

Kill unnecessary fddef->timer.

Signed-off-by: Tejun Heo <htejun@gmail.com>
Cc: Dipankar Sarma <dipankar@in.ibm.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
fs/file.c