]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
saa7134: fix thread shutdown handling
authorJeff Mahoney <jeffm@suse.com>
Wed, 27 Jun 2007 21:09:58 +0000 (14:09 -0700)
committerLinus Torvalds <torvalds@woody.linux-foundation.org>
Thu, 28 Jun 2007 18:34:54 +0000 (11:34 -0700)
commit58e78475ec706f93e0cc049449ffd11fbfdadb3e
treeccafbe9237cb4918c2b725cc64192f3b3b7b57ee
parent53f3bed0a46c786b17f040005b1bd7a78ddd0770
saa7134: fix thread shutdown handling

This patch changes the test for the thread pid from >= 0 to > 0.

When the saa8134 driver initialization fails after a certain point, it goes
through the complete shutdown process for the driver.  Part of shutting it
down includes tearing down the thread for tv audio.

The test for tearing down the thread tests for >= 0.  Since the dev
structure is kzalloc'd, the test will always be true if we haven't tried to
start the thread yet.  We end up waiting on pid 0 to complete, which will
never happen, so we lock up.

This bug was observed in Novell Bugzilla 284718, when request_irq() failed.

Signed-off-by: Jeff Mahoney <jeffm@suse.com>
Acked-by: Mauro Carvalho Chehab <mchehab@infradead.org>
Cc: <stable@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/media/video/saa7134/saa7134-tvaudio.c