]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
function tracing: fix wrong pos computing when read buffer has been fulfilled
authorwalimis <walimisdev@gmail.com>
Sat, 15 Nov 2008 07:19:06 +0000 (15:19 +0800)
committerIngo Molnar <mingo@elte.hu>
Sun, 16 Nov 2008 07:32:05 +0000 (08:32 +0100)
commit5821e1b74f0d08952cb5da4bfd2d9a388d8df58e
treee7bade7c500b2d4cd4d8c811a26c844c6f529366
parentee51a1de7e3837577412be269e0100038068e691
function tracing: fix wrong pos computing when read buffer has been fulfilled

Impact: make output of available_filter_functions complete

phenomenon:

The first value of dyn_ftrace_total_info is not equal with
`cat available_filter_functions | wc -l`, but they should be equal.

root cause:

When printing functions with seq_printf in t_show, if the read buffer
is just overflowed by current function record, then this function
won't be printed to user space through read buffer, it will
just be dropped. So we can't see this function printing.

So, every time the last function to fill the read buffer, if overflowed,
will be dropped.

This also applies to set_ftrace_filter if set_ftrace_filter has
more bytes than read buffer.

fix:

Through checking return value of seq_printf, if less than 0, we know
this function doesn't be printed. Then we decrease position to force
this function to be printed next time, in next read buffer.

Another little fix is to show correct allocating pages count.

Signed-off-by: walimis <walimisdev@gmail.com>
Acked-by: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
kernel/trace/ftrace.c