]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
[PATCH] i386: fix dubious segment register clear in cpu_init()
authorJeremy Fitzhardinge <jeremy@goop.org>
Tue, 26 Sep 2006 08:52:34 +0000 (10:52 +0200)
committerAndi Kleen <andi@basil.nowhere.org>
Tue, 26 Sep 2006 08:52:34 +0000 (10:52 +0200)
commit5758d5dfef1c514200bda3f29ba700f1c3e3bc99
tree7d2c859f875d0d5f1eacfbec66d4a9259aaa4893
parent3b8d1fe0f28202ce1592d9fbc216959b49b72c95
[PATCH] i386: fix dubious segment register clear in cpu_init()

Fix a very dubious piece of code in
arch/i386/kernel/cpu/common.c:cpu_init().  This clears out %fs and
%gs, but clobbers %eax in the process without telling gcc.  It turns
out that gcc happens to be not using %eax at that point anyway so it
doesn't matter much, but it looks like a bomb waiting to go off.

This does end up saving an instruction, because gcc wants %eax==0 for
the set_debugreg()s below.

Signed-off-by: Jeremy Fitzhardinge <jeremy@goop.org>
Signed-off-by: Andi Kleen <ak@suse.de>
arch/i386/kernel/cpu/common.c