]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
[PATCH] powerpc/iseries: Fix double phys_to_abs bug in htab_bolt_mapping
authorMichael Ellerman <michael@ellerman.id.au>
Tue, 28 Feb 2006 03:54:26 +0000 (14:54 +1100)
committerPaul Mackerras <paulus@samba.org>
Tue, 28 Feb 2006 05:25:55 +0000 (16:25 +1100)
commit56ec6462af9cba56a04439154e5768672d6f390f
treeb2e63269452da95da566d5f675f1f8b277f7f72d
parent273d2803817c9e050e8d6c3c271db7d61f2fb259
[PATCH] powerpc/iseries: Fix double phys_to_abs bug in htab_bolt_mapping

Before the merge I updated create_pte_mapping() to work for iSeries, by
calling iSeries_hpte_bolt_or_insert. (4c55130b2aa93370f1bf52d2304394e91cf8ee39)

Later we changed iSeries_hpte_insert to cope with the bolting case, and called
that instead from create_pte_mapping() (which was renamed to htab_bolt_mapping)
(3c726f8dee6f55e96475574e9f645327e461884c).

Unfortunately that change introduced a subtle bug, where we pass an absolute
address to iSeries_hpte_insert() where it expects a physical address. This
leads to us calling phys_to_abs() twice on the physical address, which is
seriously bogus.

This only causes a problem if the absolute address from the first translation
can be looked up again in the chunk_map, which depends on the size and layout
of memory. I've seen it fail on one box, but not others.

The minimal fix is to pass the physical address to iSeries_hpte_insert(). For
2.6.17 we should make phys_to_abs() BUG if we try to double-translate an
address.

Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
Signed-off-by: Paul Mackerras <paulus@samba.org>
arch/powerpc/mm/hash_utils_64.c