]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
compat_do_execve should unshare_files
authorHugh Dickins <hugh@veritas.com>
Sat, 28 Mar 2009 23:16:03 +0000 (23:16 +0000)
committerLinus Torvalds <torvalds@linux-foundation.org>
Sun, 29 Mar 2009 00:30:00 +0000 (17:30 -0700)
commit53e9309e01277ec99c38e84e0ca16921287cf470
treebc70d617e1898e5b0fdf161edafa1808ae8fa529
parent07d43ba98621f08e252a48c96b258b4d572b0257
compat_do_execve should unshare_files

2.6.26's commit fd8328be874f4190a811c58cd4778ec2c74d2c05
"sanitize handling of shared descriptor tables in failing execve()"
moved the unshare_files() from flush_old_exec() and several binfmts
to the head of do_execve(); but forgot to make the same change to
compat_do_execve(), leaving a CLONE_FILES files_struct shared across
exec from a 32-bit process on a 64-bit kernel.

It's arguable whether the files_struct really ought to be unshared
across exec; but 2.6.1 made that so to stop the loading binary's fd
leaking into other threads, and a 32-bit process on a 64-bit kernel
ought to behave in the same way as 32 on 32 and 64 on 64.

Signed-off-by: Hugh Dickins <hugh@veritas.com>
Cc: stable@kernel.org
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
fs/compat.c