]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
configfs: Protect configfs_dirent s_links list mutations
authorLouis Rilling <Louis.Rilling@kerlabs.com>
Mon, 16 Jun 2008 17:00:59 +0000 (19:00 +0200)
committerMark Fasheh <mfasheh@suse.com>
Mon, 14 Jul 2008 20:57:16 +0000 (13:57 -0700)
commit5301a77da2da1e4c22573e0e8d394a653b8ad9f9
treec2a6186510c3a4502d923cf3f5d445fa821cb277
parent6f61076406251626be39651d114fac412b1e0c39
configfs: Protect configfs_dirent s_links list mutations

Symlinks to a config_item are listed under its configfs_dirent s_links, but the
list mutations are not protected by any common lock.

This patch uses the configfs_dirent_lock spinlock to add the necessary
protection.

Note: we should also protect the list_empty() test in configfs_detach_prep() but
1/ the lock should not be released immediately because nothing would prevent the
list from being filled after a successful list_empty() test, making the problem
tricky,
2/ this will be solved by the rmdir() vs rename() deadlock bugfix.

Signed-off-by: Louis Rilling <Louis.Rilling@kerlabs.com>
Signed-off-by: Joel Becker <joel.becker@oracle.com>
fs/configfs/dir.c
fs/configfs/symlink.c