]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
tcp: fix length used for checksum in a reset
authorIlpo Järvinen <ilpo.jarvinen@helsinki.fi>
Wed, 8 Oct 2008 18:34:06 +0000 (11:34 -0700)
committerDavid S. Miller <davem@davemloft.net>
Wed, 8 Oct 2008 18:34:06 +0000 (11:34 -0700)
commit52cd5750e81ec8d213949fa7c0d2e08907bf498b
tree10e7a8127022e99bf6e729fe04420fa82a0997a8
parent2ca89cea5c9fdafd495fb840fa055383d253174e
tcp: fix length used for checksum in a reset

While looking for some common code I came across difference
in checksum calculation between tcp_v6_send_(reset|ack) I
couldn't explain. I checked both v4 and v6 and found out that
both seem to have the same "feature". I couldn't find anything
in rfc nor anywhere else which would state that md5 option
should be ignored like it was in case of reset so I came to
a conclusion that this is probably a genuine bug. I suspect
that addition of md5 just was fooled by the excessive
copy-paste code in those functions and the reset part was
never tested well enough to find out the problem.

Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/tcp_ipv4.c
net/ipv6/tcp_ipv6.c