]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
drivers/isdn/capi/kcapi.c: Adjust error handling code involving capi_ctr_put
authorJulia Lawall <julia@diku.dk>
Tue, 23 Sep 2008 02:04:54 +0000 (19:04 -0700)
committerDavid S. Miller <davem@davemloft.net>
Tue, 23 Sep 2008 02:04:54 +0000 (19:04 -0700)
commit4d5392cc4de3403d71b929f39f3bc659db029ad1
tree42d7deba9115f39fb804beca674310c20e9cfb07
parent2cdc55751c33829f00510e0104562d0f8d8a9b85
drivers/isdn/capi/kcapi.c: Adjust error handling code involving capi_ctr_put

After calling capi_ctr_get, error handling code should call capi_ctr_put.

The semantic match that finds this problem is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@r@
expression x,E;
statement S;
position p1,p2,p3;
@@

(
if ((x = capi_ctr_get@p1(...)) == NULL || ...) S
|
x = capi_ctr_get@p1(...)
... when != x
if (x == NULL || ...) S
)
<...
if@p3 (...) { ... when != capi_ctr_put(x)
                  when != if (x) { ... capi_ctr_put(x); ...}
    return@p2 ...;
}
...>
(
return x;
|
return 0;
|
x = E
|
E = x
|
capi_ctr_put(x)
)

@exists@
position r.p1,r.p2,r.p3;
expression x;
int ret != 0;
statement S;
@@

* x = capi_ctr_get@p1(...)
  <...
* if@p3 (...)
  S
  ...>
* return@p2 \(NULL\|ret\);
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/isdn/capi/kcapi.c