]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
mmap_region: cleanup the final vma_merge() related code
authorOleg Nesterov <oleg@tv-sign.ru>
Mon, 28 Apr 2008 09:12:10 +0000 (02:12 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Mon, 28 Apr 2008 15:58:18 +0000 (08:58 -0700)
commit4d3d5b41a72b52555d43efbfc4ccde6ba6e5444f
tree5935f5d9e741f63c190c4edf4d5f6f6005e33d0f
parent0dd1334faf7e075bfdb6f5284eed65210b296fc1
mmap_region: cleanup the final vma_merge() related code

It is not easy to actually understand the "if (!file || !vma_merge())"
code, turn it into "if (file && vma_merge())".  This makes immediately
obvious that the subsequent "if (file)" is superfluous.

As Hugh Dickins pointed out, we can also factor out the ->i_writecount
corrections, and add a small comment about that.

Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
Cc: Miklos Szeredi <miklos@szeredi.hu>
Cc: Hugh Dickins <hugh@veritas.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
mm/mmap.c