]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
libata: don't normalize UNKNOWN to NONE after reset
authorTejun Heo <htejun@gmail.com>
Tue, 8 Jan 2008 11:26:12 +0000 (20:26 +0900)
committerJeff Garzik <jeff@garzik.org>
Thu, 10 Jan 2008 21:53:22 +0000 (16:53 -0500)
commit4ccd3329a2e51473a86547a55f9e5f98f8f65b33
tree40ef0e858a162c29b8a56392365588333b6eeb1e
parent2695e36616c3ece5e8e30666868fc7c90dc3fc75
libata: don't normalize UNKNOWN to NONE after reset

After non-classifying reset, ehc->classes[] could contain
ATA_DEV_UNKNOWN which used to be normalized to ATA_DEV_NONE for
consistency.  However, this causes unfortunate side effect for drivers
which have non-classifying hardresets (e.g. sata_nv) by making
hardreset report ATA_DEV_NONE for non-classifying resets and thus
makes EH believe that the port is unoccupied and recovery can be
skipped.  The end result is that after a device is swapped with
another one, the new device isn't attached after the old one is
detached.

This patch makes ata_eh_reset() not normalize UNKNOWN to NONE after
non-classifying resets.  This fixes the above problem.  As UNKNOWN and
NONE are handled differently by only EH hotplug logic, this doesn't
cause other behavior changes.

Signed-off-by: Tejun Heo <htejun@gmail.com>
Cc: Robert Hancock <hancockr@shaw.ca>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
drivers/ata/libata-eh.c