]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
[TULIP] DMFE: Fix SROM parsing regression.
authorDavid S. Miller <davem@davemloft.net>
Tue, 22 Jan 2008 07:20:58 +0000 (23:20 -0800)
committerDavid S. Miller <davem@davemloft.net>
Wed, 23 Jan 2008 11:11:39 +0000 (03:11 -0800)
commit4c93566e2a61b48ef071a8d8a8fa9904c83a668e
tree5da4dffee090f69d3194fab20e5124e0ce3cba42
parentacea6852f32b8805e166d885ed7e9f0c7cd10d41
[TULIP] DMFE: Fix SROM parsing regression.

Changeset 16b110c3fd760620b4a787db6ed512fe531ab1b5 (dmfe warning fix)
bothed up the offsets read from the SROM so that it doesn't read the
same datums it used to.

The change made transformations like turning:

"srom + 34"

into

"(__le32 *)srom + 34/4"

which doesn't work because 4 does not divide evenly
into 34 so we're using a different pointer offset
than in the original code.

I've changed theses cases in dmfe_parse_srom() to
consistently use "(type *)(srom + offset)" preserving
the offsets from the original code.

Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/tulip/dmfe.c