]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
[JFFS2] fix mount crash caused by removed nodes
authorThomas Gleixner <tglx@linutronix.de>
Mon, 16 Feb 2009 20:29:31 +0000 (21:29 +0100)
committerDavid Woodhouse <David.Woodhouse@intel.com>
Sat, 21 Feb 2009 10:09:29 +0000 (11:09 +0100)
commit4c41bd0ec953954158f92bed5d3062645062b98e
treebd3f4c7fdbcac9bf2cabce557d472d6ed4ae4741
parentefab0b5d3eed6aa71f8e3233e4e11774eedc04dc
[JFFS2] fix mount crash caused by removed nodes

At scan time we observed following scenario:

   node A inserted
   node B inserted
   node C inserted -> sets overlapped flag on node B

   node A is removed due to CRC failure -> overlapped flag on node B remains

   while (tn->overlapped)
     tn = tn_prev(tn);

   ==> crash, when tn_prev(B) is referenced.

When the ultimate node is removed at scan time and the overlapped flag
is set on the penultimate node, then nothing updates the overlapped
flag of that node. The overlapped iterators blindly expect that the
ultimate node does not have the overlapped flag set, which causes the
scan code to crash.

It would be a huge overhead to go through the node chain on node
removal and fix up the overlapped flags, so detecting such a case on
the fly in the overlapped iterators is a simpler and reliable
solution.

Cc: stable@kernel.org
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
fs/jffs2/readinode.c