]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
firewire: fw-sbp2: fix another small generation access bug
authorStefan Richter <stefanr@s5r6.in-berlin.de>
Sat, 9 Aug 2008 18:22:17 +0000 (20:22 +0200)
committerStefan Richter <stefanr@s5r6.in-berlin.de>
Wed, 15 Oct 2008 20:21:10 +0000 (22:21 +0200)
commit4bbc1bdd010cbfcb749e4f947161ec3ab3337893
tree77478b6c1bc693ba4dbddd4bd14c063846ec63c9
parent09b12dd4e3caff165a0f17a2f3ebd2bbc8544cc6
firewire: fw-sbp2: fix another small generation access bug

queuecommand() looked at the remote and local node IDs before it read
the bus generation.  The corresponding race with sbp2_reconnect updating
these data was probably impossible to happen though because the current
code blocks the SCSI layer during reconnection.  However, better safe
than sorry, especially if someone later improves the code to not block
the SCSI layer.

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
drivers/firewire/fw-sbp2.c