]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
md: raid5: fix clearing of biofill operations
authorDan Williams <dan.j.williams@intel.com>
Tue, 23 Oct 2007 03:45:11 +0000 (20:45 -0700)
committerLinus Torvalds <torvalds@woody.linux-foundation.org>
Tue, 23 Oct 2007 15:32:06 +0000 (08:32 -0700)
commit4ae3f847e49e3787eca91bced31f8fd328d50496
tree9fab60c4898e49cf1cf04e360dc63ae1d0ef5bd2
parent85bfb4da8cad483a4e550ec89060d05a4daf895b
md: raid5: fix clearing of biofill operations

ops_complete_biofill() runs outside of spin_lock(&sh->lock) and clears the
'pending' and 'ack' bits.  Since the test_and_ack_op() macro only checks
against 'complete' it can get an inconsistent snapshot of pending work.

Move the clearing of these bits to handle_stripe5(), under the lock.

Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Tested-by: Joel Bertrand <joel.bertrand@systella.fr>
Signed-off-by: Neil Brown <neilb@suse.de>
Cc: Stable <stable@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/md/raid5.c