]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
genirq: warn when IRQF_DISABLED may be ignored
authorDavid Brownell <dbrownell@users.sourceforge.net>
Mon, 1 Dec 2008 22:31:37 +0000 (14:31 -0800)
committerIngo Molnar <mingo@elte.hu>
Tue, 2 Dec 2008 10:25:29 +0000 (11:25 +0100)
commit470c66239ef0336429b35345f3f615d47341e13b
tree8816b081041daa9b5f8332b0c803678cbbd04e1f
parent7807fafa52b990abb321f1212416c71e64523ecb
genirq: warn when IRQF_DISABLED may be ignored

Impact: emit new warning

We periodically waste time tracking down problems from the genirq
framework not respecting IRQF_DISABLED for some shared IRQ cases.  Linus
views this as "will not fix", but we're still left with the bugs caused by
this misbehavior.

This patch adds a nag message in request_irq(), so that drivers can fix
their IRQ handlers to avoid this problem.

Note that developers will never see the relevant bugs when they run with
LOCKDEP, so it's no wonder these bugs are hard to find.  (That also means
LOCKDEP is overlooking some IRQ-related bugs involving IRQ handlers that
don't set IRQF_DISABLED...)

Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Acked-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
kernel/irq/manage.c