]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
powerpc: Fix no interrupt handling in pata_of_platform
authorAnton Vorontsov <avorontsov@ru.mvista.com>
Mon, 6 Oct 2008 07:26:54 +0000 (07:26 +0000)
committerBenjamin Herrenschmidt <benh@kernel.crashing.org>
Fri, 10 Oct 2008 04:55:17 +0000 (15:55 +1100)
commit4538d0ca71b4f8991c4c0f433d7d17805738326e
tree2d7e4ea97a8a19280514375c59612d20a841c848
parent9fd3f88cb67ac51bd5face8441472b91e042be67
powerpc: Fix no interrupt handling in pata_of_platform

When no interrupt is specified the pata_of_platform fills the irq_res
resource with -1, which is wrong to do for two reasons:

1. By definition, 'no irq' should be IRQ 0, not some negative integer;
2. pata_platform checks for irq_res.start > 0, but since irq_res.start
   is unsigned type, the check will be true for `-1'.

Reported-by: Steven A. Falco <sfalco@harris.com>
Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
drivers/ata/pata_of_platform.c