]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
drivers/net/wireless/libertas: move a dereference below a NULL test
authorJulia Lawall <julia@diku.dk>
Fri, 9 Jan 2009 10:23:10 +0000 (10:23 +0000)
committerDavid S. Miller <davem@davemloft.net>
Sun, 11 Jan 2009 08:06:35 +0000 (00:06 -0800)
commit43baa5bb26298e8e268056c58900098ce8454548
tree705280b85ec59628cc1433ec5ea5976da351387b
parent0397a2648434a65d73564216c4f96945c192ad4a
drivers/net/wireless/libertas: move a dereference below a NULL test

In each case, if the NULL test is necessary, then the dereference should be
moved below the NULL test.  I have also taken advantage of the availability
of the value of priv->dev in the subsequent calls to netif_stop_queue and
netif_carrier_off.

The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@@
type T;
expression E;
identifier i,fld;
statement S;
@@

- T i = E->fld;
+ T i;
  ... when != E
      when != i
  if (E == NULL) S
+ i = E->fld;
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Dan Williams <dcbw@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/wireless/libertas/main.c