]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
ACPI: scheduling in atomic via acpi_evaluate_integer ()
authorPavel Machek <pavel@suse.cz>
Tue, 25 Nov 2008 11:05:08 +0000 (12:05 +0100)
committerLen Brown <len.brown@intel.com>
Wed, 26 Nov 2008 22:39:06 +0000 (17:39 -0500)
commit40599072dca3ec7d4c9ff8271978be169f974638
treec7a4f34e547aadb47644f57bb1c96a8ad9c24689
parent558073dd56707864f09d563b64e7c37c021e89d2
ACPI: scheduling in atomic via acpi_evaluate_integer ()

Now I know why I had strange "scheduling in atomic" problems:
acpi_evaluate_integer() does malloc(..., irqs_disabled() ? GFP_ATOMIC
: GFP_KERNEL)... which is (of course) broken.

There's no way to reliably tell if we need GFP_ATOMIC or not from
code, this one for example fails to detect spinlocks held.

Fortunately, allocation seems small enough to be done on stack.

Signed-off-by: Pavel Machek <pavel@suse.cz>
Acked-by: Bob Moore <robert.moore@intel.com>
Signed-off-by: Len Brown <len.brown@intel.com>
drivers/acpi/utils.c