]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
[SCSI] sd: revive sd_index_lock
authorTejun Heo <tj@kernel.org>
Sat, 21 Feb 2009 02:04:45 +0000 (11:04 +0900)
committerJames Bottomley <James.Bottomley@HansenPartnership.com>
Sun, 22 Feb 2009 02:29:38 +0000 (20:29 -0600)
commit4034cc68157bfa0b6622efe368488d3d3e20f4e6
tree525106f6783eeb533df8b1e9feacd7457042d1d9
parentb7e7bd34465518f3527bf47a8055f35077d40c6c
[SCSI] sd: revive sd_index_lock

Commit f27bac2761cab5a2e212dea602d22457a9aa6943 which converted sd to
use ida instead of idr incorrectly removed sd_index_lock around id
allocation and free.  idr/ida do have internal locks but they protect
their free object lists not the allocation itself.  The caller is
responsible for that.  This missing synchronization led to the same id
being assigned to multiple devices leading to oops.

Reported and tracked down by Stuart Hayes of Dell.

Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Stable Tree <stable@kernel.org>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
drivers/scsi/sd.c