]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
pkt_sched: sch_drr: fix drr_dequeue loop()
authorPatrick McHardy <kaber@trash.net>
Mon, 24 Nov 2008 23:46:08 +0000 (15:46 -0800)
committerDavid S. Miller <davem@davemloft.net>
Mon, 24 Nov 2008 23:46:08 +0000 (15:46 -0800)
commit3f0947c3ffaed33c1c38b79e4b17f75ba072d3e9
treeaabc1d3fadbfbfb97b2fe56884fad70197e50d47
parent4b40eed73e3787d60160beed1352ceadd24f6be1
pkt_sched: sch_drr: fix drr_dequeue loop()

Jarek Poplawski points out:

If all child qdiscs of sch_drr are non-work-conserving (e.g. sch_tbf)
drr_dequeue() will busy-loop waiting for skbs instead of leaving the
job for a watchdog. Checking for list_empty() in each loop isn't
necessary either, because this can never be true except the first time.

Using non-work-conserving qdiscs as children of DRR makes no sense,
simply bail out in that case.

Reported-by: Jarek Poplawski <jarkao2@gmail.com>
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sched/sch_drr.c